Skip to content

Begin the steps to release 1.0.15 #3456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2015
Merged

Conversation

abersnaze
Copy link
Contributor

Can get two more 👍 from the committers.

@akarnokd
Copy link
Member

It would be great to get these PRs in as well:

#3458 : CompositeSubscription javadoc change
#3455 : [Bug] OnErrorFailedException propagation fix
#3454 : [Bug] Fix bounded replay() request behavior
#3438 : Better null tolerance, although this may need rebase due to #3455

* [Pull 3418] (https://github.com/ReactiveX/RxJava/pull/3418) Add Single.fromCallable()
* [Pull 3419] (https://github.com/ReactiveX/RxJava/pull/3419) Add Single.doOnError()
* [Pull 3423] (https://github.com/ReactiveX/RxJava/pull/3423) Renaming Observable#x to Observable#extend
* [Pull 3422] (https://github.com/ReactiveX/RxJava/pull/3422) Update README.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line isn't needed since it's not actually affecting code or functionality.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing.

@benjchristensen
Copy link
Member

👍 for getting this release out. I provided some non-essential feedback on suggestions for things I would change or not include in the release notes based on how I've done it in thus far. With or without those changes (except the one I thing has a misleading title), I'm good with the release going out.

@benjchristensen
Copy link
Member

Agreed that we should get the items @akarnokd mentioned into this release. Some are already merged and just need to be put in the release notes. I've looked at the others and think they are all okay for merging before release.

@akarnokd
Copy link
Member

Great, these are already merged in:

#3458 : CompositeSubscription javadoc change
#3455 : [Bug] OnErrorFailedException propagation fix
#3438 : Better null tolerance, although this may need rebase due to #3455

I feel this one can be merged but would like someone to review it in more detail:

#3454 : [Bug] Fix bounded replay() request behavior

I don't know how urgent are these as they were reported by Netflix:

#3428 [bug] GroupBy request fix
#3169 Merge support for horizontally unbounded mode

@stealthcode
Copy link

👍

@stealthcode
Copy link

I think I'd prefer to cut a release of 1.0.15 asap and get the changes like #3454, #3428, and #3169 in a subsequent 1.0.16 release.

Can I get a +1 to initiate the 1.0.15 release?

@artem-zinnatullin
Copy link
Contributor

👍 (not a "collaborator" though). Let's finally release 1.0.15, a lot of good stuff for Rx users!

@abersnaze can you please squash commits in this PR?

@benjchristensen
Copy link
Member

+1 for release of what is already merged.

@akarnokd
Copy link
Member

👍

@abersnaze
Copy link
Contributor Author

I was getting lazy. thanks @artem-zinnatullin.

abersnaze added a commit that referenced this pull request Oct 30, 2015
Begin the steps to release 1.0.15
@abersnaze abersnaze merged commit 51527b7 into ReactiveX:1.x Oct 30, 2015
@stevegury
Copy link
Member

👍

@abersnaze abersnaze deleted the 1.0.15 branch November 4, 2015 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants